[lworld] RFR: 8334140: [lworld] -XX:LockingMode=0 ignored makes MapLoops fail [v2]

David Simms dsimms at openjdk.org
Thu Jun 13 07:50:21 UTC 2024


On Wed, 12 Jun 2024 20:37:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The MapLoops test uses `-XX:LockingMode=0 -XX:+VerifyHeavyMonitors ` for a debug test run.
>> However, the LockingMode command line option is overridden in arguments.cpp when 
>> Valhalla is enabled and it forces the lock mode to be LM_LEGACY.
>> 
>> The default for lightweight locking should only be overridden if Valhalla is enabled.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove extraneous whitespace

LGTM, thanks

-------------

Marked as reviewed by dsimms (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1124#pullrequestreview-2114995763



More information about the valhalla-dev mailing list