[lworld] RFR: 8333675: [lworld] Handling of invalid class files [v2]

[David Holmes]

On Tue, 11 Jun 2024 19:18:43 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Improve detection of invalid class files and test coverage of invalid scenarios.
>> 
>> Tested with Mach5, tier 1 to 3.
>
> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/lworld' into invalid_classes
>  - Merge remote-tracking branch 'upstream/lworld' into invalid_classes
>  - Remove obsolete tests
>  - More tests of VM fixing missing ACC_IDENTITY
>  - Fix Copyright years
>  - Add test checking that VM fixes missing ACC_IDENTITY in old class files
>  - Add field tests for abstract value classes
>  - Detect missing exception and other fixes
>  - Merge remote-tracking branch 'upstream/lworld' into invalid_classes
>  - Improve class validation and test coverage

src/hotspot/share/classfile/classFileParser.cpp line 4744:

> 4742:       class_note = " (a value class must be final or else abstract)";
> 4743:     }
> 4744:     if (!is_identity)  class_note = " (a value class)";

@fparain you needed to delete line 4744 when incorporating my changes. Now you have overwritten the detailed message. I can fix that in my upcoming changes.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1114#discussion_r1639128993