[lworld] RFR: 8326597: [lworld] Verifier must enforce new JEP 401 rules related to strict fields

Frederic Parain fparain at openjdk.org
Fri Jun 14 02:57:47 UTC 2024


On Fri, 31 May 2024 05:22:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/classfile/verifier.cpp line 2403:
>> 
>>> 2401:           stack_object_type = current_type();
>>> 2402:         }
>>> 2403:       } else if (supports_value_types(_klass)) {
>> 
>> The mention of value types here could be confusing.
>> What about changing `supports_value_types()` to `supports_strict_fields()`?
>
> I was copying/emulating the use of `ClassFileParser::supports_inline_types` but changing `inline` to `value`. I can change to `supports_strict_fields` for this new code, but the Classfile parser uses `inline types` to cover both cases (not that I expect to have one without the other).

Maybe changing both to `supports_jep_401()` ?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1109#discussion_r1624525405



More information about the valhalla-dev mailing list