[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v12]

Bhavana Kilambi bkilambi at openjdk.org
Fri Jun 14 11:08:32 UTC 2024


On Fri, 14 Jun 2024 05:08:34 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Sketch of a more full-featured API for Float16.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor code, refine spec, add tests.

src/java.base/share/classes/java/lang/Float16.java line 736:

> 734:      */
> 735:     // @IntrinsicCandidate
> 736:     public static Float16 add(Float16 addend, Float16 augend) {

Hi, thanks for implementing these operations for Float16. May I ask why do we have both `Float16 sum()` and `Float16 add()`? Also, both seem to be marked as `@IntrinsicsCandidate`.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1639661924



More information about the valhalla-dev mailing list