[lworld] RFR: 8326597: [lworld] Verifier must enforce new JEP 401 rules related to strict fields
David Holmes
dholmes at openjdk.org
Mon Jun 17 04:40:24 UTC 2024
On Fri, 14 Jun 2024 17:45:18 GMT, Frederic Parain <fparain at openjdk.org> wrote:
>> There are a number of commits here relating to different changes. To keep things more simple you can look at them individually.
>>
>> Changes:
>> - removed the old Q-type support from the verifier (verifierType.hpp/cpp)
>> - added the necessary checks for strict fields to the verifier and added some tests
>> - added missing class modifier checks for value classes in the classfile parse
>> - brought the field modifier checks in classfile parser into line with JEP 401, simplified logic and provided more informative exception messages.
>> - updated existing tests to support the above
>>
>> There is still a lot of inline-type terminology remaining, at least some of which should be cleaned up in future RFE's
>
> Looks good to me.
Thanks for the review @fparain !
Do I need further reviews?
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1109#issuecomment-2172222239
More information about the valhalla-dev
mailing list