[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v12]

Bhavana Kilambi bkilambi at openjdk.org
Mon Jun 17 09:02:30 UTC 2024


On Fri, 14 Jun 2024 05:08:34 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Sketch of a more full-featured API for Float16.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor code, refine spec, add tests.

test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorSum.java line 33:

> 31: */
> 32: 
> 33: package compiler.vectorization;

I am not able to add comments to the lines above this line. I see "-XDenablePrimitiveClasses" flag on line #29 which I think is obsolete after the latest merge. If this test passes for you then you can leave this unchanged. I can change this line in my next PR. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1642457121


More information about the valhalla-dev mailing list