[lworld] RFR: 8326597: [lworld] Verifier must enforce new JEP 401 rules related to strict fields
    David Holmes 
    dholmes at openjdk.org
       
    Tue Jun 18 06:03:24 UTC 2024
    
    
  
On Mon, 17 Jun 2024 13:26:48 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:
>> There are a number of commits here relating to different changes. To keep things more simple you can look at them individually.
>> 
>> Changes:
>> - removed the old Q-type support from the verifier (verifierType.hpp/cpp)
>> - added the necessary checks for strict fields to the verifier and added some tests
>> - added missing class modifier checks for value classes in the classfile parse
>> - brought the field modifier checks in classfile parser into line with JEP 401, simplified logic and provided more informative exception messages.
>> - updated existing tests to  support the above
>> 
>> There is still a lot of inline-type terminology remaining, at least some of which should be cleaned up in future RFE's
>
> All my concerns were addressed.  Looks good
Thanks @DanHeidinga !
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1109#issuecomment-2175076736
    
    
More information about the valhalla-dev
mailing list