[lworld] RFR: 8294866: [lworld] Array classes access flags should include identity bits [v2]

[Vicente Romero]

On Thu, 20 Jun 2024 16:45:35 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Update java.lang.reflect.AccessFlag to return IDENTITY for array classes.
>> The access flag bits for arrays come from the VM, hence the changes to HotSpot.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tagged the new IDENTITY and STRICT_FIELD AccessFlags to be valid as of the `latest()` class file version number.
>   They should float forward with releases until the first release in which Valhalla is integrated.

just wondering now that you are modifying AccessFlag, should we change SUPER:

SUPER(0x0000_0020, false,
            PreviewFeatures.isEnabled() ? Location.EMPTY_SET : Location.SET_CLASS,
            new Function<ClassFileFormatVersion, Set<Location>>() {
            @Override
            public Set<Location> apply(ClassFileFormatVersion cffv) {
-               return (cffv.compareTo(ClassFileFormatVersion.RELEASE_22) >= 0) &&
+               return (cffv.compareTo(ClassFileFormatVersion.RELEASE_23) >= 0) &&
                        PreviewFeatures.isEnabled() ? Location.EMPTY_SET : Location.SET_CLASS;
            }
        }),

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1141#issuecomment-2181231226