[lworld] RFR: 8327150: [lworld] Update C1 to support new value construction scheme from JEP 401

Frederic Parain fparain at openjdk.org
Mon Mar 4 14:38:09 UTC 2024


On Fri, 1 Mar 2024 20:57:08 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Fix value creation in C1, remove the old special node for value creation and out everything under the NewInstance node.
> There's also a fix in can_be_inline_klass() method that was causing a wrong behavior for acmp.

Those fixes allow many C1 tests to pass, for instance all tests in TestC1.java now pass in scenarios #0 and #3, but the whole test fails because of scenarios #1 and #4 which involve C2.
Running all tests in test/hotspot/jtreg/compiler/valhalla/inlinetypes with `-XX:TieredStopAtLevel=3` shows many errors due to C2 (`assert(false) failed: Should have been buffered`), some verifier errors, and some tests not compliant with the new type hierarchy rules for value classes. But unless I missed them, I didn't notice failures directly caused by C1. However, it doesn't guarantee that once fixed, the problematic tests mentioned above will pass with C1.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1029#issuecomment-1976716141



More information about the valhalla-dev mailing list