[lworld] RFR: 8327639: [lworld] test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java fails with --enable-preview [v2]

Roger Riggs rriggs at openjdk.org
Mon Mar 11 18:47:43 UTC 2024


> The test contains a bug in which it attempts to use streams from ModuleReader.list() after the ModuleReader has been closed.  Closing ModuleReader closes the underlying streams to the Jar/Zip file.
> 
> The bug is only exercised when a patched module is read. Currently, --enable-preview uses module patching of the java.base module to include a set of classes that have been converted to be value classes.
> 
> The test is modified to cache the results of the stream in a List and keep the scoped structure used by try-with-resources.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Compute the list of caller sensitive methods only once yielding a slight performance improvement.

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1042/files
  - new: https://git.openjdk.org/valhalla/pull/1042/files/f0b3f4f0..0348ab38

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1042&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1042&range=00-01

  Stats: 16 lines in 1 file changed: 8 ins; 3 del; 5 mod
  Patch: https://git.openjdk.org/valhalla/pull/1042.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1042/head:pull/1042

PR: https://git.openjdk.org/valhalla/pull/1042



More information about the valhalla-dev mailing list