[lworld] RFR: 8304168: [lworld] CDS tests fail with --enable-preview patched value classes

Ioi Lam iklam at openjdk.org
Tue Mar 26 15:55:42 UTC 2024


[1] Allow `--enable-preview -XX:+EnableValhalla` to be specified when dumping a CDS archive. This allows only the patch modules that are used for the value classes. The user is still forbidden from specifying --patch-module when dumping the CDS archive.

[2] If a CDS archive was created with `--enable-preview -XX:+EnableValhalla`, then it must also be specified at run time, or else the CDS archive will be ignored.

[3] Fixed a few bugs with value types. E.g., some metadata objects need to be placed in R/W region.

[4] Tests with all CDS tests and tiers 1-4.

[5] Modify Image.gmk to be able to generate default CDS archives for `--enable-preview -XX:+EnableValhalla`, but this is not yet enabled as some non-CDS tests will fail. See [JDK-8329108](https://bugs.openjdk.org/browse/JDK-8329108)

-------------

Commit messages:
 - 8304168: [lworld] CDS tests fail with --enable-preview patched value classes

Changes: https://git.openjdk.org/valhalla/pull/1063/files
  Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=1063&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8304168
  Stats: 252 lines in 25 files changed: 149 ins; 23 del; 80 mod
  Patch: https://git.openjdk.org/valhalla/pull/1063.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1063/head:pull/1063

PR: https://git.openjdk.org/valhalla/pull/1063



More information about the valhalla-dev mailing list