[lworld] RFR: 8328543: [lworld] Library and test updates to use --enable-preview instead of ValhallaFeatures [v5]
Mandy Chung
mchung at openjdk.org
Wed Mar 27 20:27:45 UTC 2024
On Wed, 27 Mar 2024 17:35:48 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Update AccessFlag and tests to JEP 401 and use of --enable-preview instead of ValhallaFeatures.
>> Minor formatting change to java.lang.Character to allow it to be a value class with --enable-preview.
>> (The class file format version numbers will need to be updated when re-synching with the mainline).
>
> Roger Riggs has updated the pull request incrementally with two additional commits since the last revision:
>
> - remove extraneous text
> - Update src/java.base/share/classes/java/lang/reflect/AccessFlag.java
>
> Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
test/jdk/java/lang/reflect/AccessFlag/BasicAccessFlagTest.java line 30:
> 28: * @modules java.base/jdk.internal.misc
> 29: * @enablePreview
> 30: * @run main/othervm --enable-preview BasicAccessFlagTest
`@enablePreview` should always add `--enable-preview` to test execution. If you want to test with preview enabled and disabled, it can't use `@enablePreview`
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1060#discussion_r1541983852
More information about the valhalla-dev
mailing list