[lworld] RFR: 8328543: [lworld] Library and test updates to use --enable-preview instead of ValhallaFeatures [v6]

Roger Riggs rriggs at openjdk.org
Thu Mar 28 19:10:41 UTC 2024


On Thu, 28 Mar 2024 17:19:17 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove extr enable preview and test code
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 364:
> 
>> 362:                public Set<Location> apply(ClassFileFormatVersion cffv) {
>> 363:                    return (cffv.compareTo(ClassFileFormatVersion.RELEASE_2)  >= 0 &&
>> 364:                            cffv.compareTo(ClassFileFormatVersion.RELEASE_16) <= 0) ?
> 
> I believe we still want to keep the strict field modifier for value class fields.

I dropped it because its not in JEP401 and the feature has not settled yet nor which spec its covered in.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1060#discussion_r1543503085



More information about the valhalla-dev mailing list