[lworld] RFR: 8304168: [lworld] CDS tests fail with --enable-preview patched value classes [v2]

[Frederic Parain]

On Wed, 27 Mar 2024 17:11:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> [1] Allow `--enable-preview -XX:+EnableValhalla` to be specified when dumping a CDS archive. This allows only the patch modules that are used for the value classes. The user is still forbidden from specifying --patch-module when dumping the CDS archive.
>> 
>> [2] If a CDS archive was created with `--enable-preview -XX:+EnableValhalla`, then it must also be specified at run time, or else the CDS archive will be ignored.
>> 
>> [3] Fixed a few bugs with value types. E.g., some metadata objects need to be placed in R/W region.
>> 
>> [4] Tests with all CDS tests and tiers 1-4.
>> 
>> [5] Modify Image.gmk to be able to generate default CDS archives for `--enable-preview -XX:+EnableValhalla`, but this is not yet enabled as some non-CDS tests will fail. See [JDK-8329108](https://bugs.openjdk.org/browse/JDK-8329108)
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed typo

Marked as reviewed by fparain (Committer).

Looks good to me, thank you for fixing CDS.

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1063#pullrequestreview-1969321336
PR Comment: https://git.openjdk.org/valhalla/pull/1063#issuecomment-2027585386