[lworld] RFR: 8330691: [lworld] C2: assert(gvn().type(n)->is_zero_type()) failed: Should have been scalarized [v2]

[Christian Hagedorn]

On Wed, 8 May 2024 10:36:52 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'lworld' into JDK-8330691
>>  - 8330691: [lworld] C2: assert(gvn().type(n)->is_zero_type()) failed: Should have been scalarized
>
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestLWorld.java line 4387:
> 
>> 4385:     @Test
>> 4386:     public void testUniqueConcreteValueSubKlass(boolean flag) {
>> 4387:         // C2 should recognize that even though we do not know whether the underlying inline type of the abstract field
> 
> Comment could be made more clear, as we discussed offline.

Thanks for the hint, pushed an update.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1099#discussion_r1593818669