[lworld+fp16] RFR: 8341414: Add support for FP16 conversion routines [v2]

[Jatin Bhateja]

On Fri, 8 Nov 2024 07:54:59 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> I would prefer if I can do this in a separate patch please? I feel this patch is big enough. I will add some Ideal/Identity transformations as required for the new IR (for ex. ConvHF2I <-> ConvI2HF return the half float etc) in the new patch.
>
>> I would prefer if I can do this in a separate patch please? I feel this patch is big enough. I will add some Ideal/Identity transformations as required for the new IR (for ex. ConvHF2I <-> ConvI2HF return the half float etc) in the new patch.
> 
> Sounds good!

> Hi @jatin-bhateja , can I integrate these changes if you feel these are good to go?

Hi @Bhavana-Kilambi ,

Kindly integrate this, you now have committer's rights :-) 

Best Regards,
Jatin

FTR, upcasting from float16 to float conversions using existing runtime helpers is precision preserving, and constant folding for newly introduced scalar IR can be performed by subsequent integral casting thereby avoiding the need for newly introduced helpers. This can be addressed in a follow-up patch, we can take this liberty on a project branch.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1283#issuecomment-2500154658