[lworld+fp16] RFR: 8341245: Add 'shortest length' toString() to Float16 [v3]
Joe Darcy
darcy at openjdk.org
Mon Oct 21 19:46:37 UTC 2024
On Fri, 4 Oct 2024 14:47:25 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> Add `Float16.toString()` with the same 'shortest length' properties as of `[Double|Float].toString()`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressing review comments.
Looks fine.
For future work, having a single copy of the floating-point value -> toString text somewhere and then having it referenced by Double::toString(double), Float::toString(float), Float16::toString(Float16) might be a better structure for the docs.
-------------
Marked as reviewed by darcy (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1260#pullrequestreview-2383163775
More information about the valhalla-dev
mailing list