[lworld] RFR: 8342276: [lworld] Apply LIBRARY.properties to stabiliize --enable-preview for tests [v2]

Roger Riggs rriggs at openjdk.org
Wed Oct 23 13:37:16 UTC 2024


> Create LIBRARY.properties files to set the value of `enablePreview` for sensitive test library roots.
> 
> The top level test library is set with `enablePreview = false` so that when compiled they will be able to be used with or without enablePreview.
> 
> Individual tests that use preview features and test library files that use preview features will need to be compiled based on the settings in each test.
> 
> Some tests are modified to remove explicit building or compilation and fall back to implicit compiles with the prevailing enablePreview setting.
> 
> There are other test library roots that declare `enablePreview = true` appropriate to their uses.

Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - change jib-profiles.js to use jtreg 7.5
   and remove unnecessary test/langtools/tools/javac/lib/LIBRARY.properties
 - Merge branch 'lworld' into 8342276-fix-library-preview
 - Remove unnecessary @enablePreview tags
 - Cleanup LIBRARY.properties files to fix remaining test issues
 - 8342276: [lworld] Apply LIBRARY.properties to stabiliize --enable-preview for tests
   Create LIBRARY.properties files to set the value of `enablePreview` for sensitive test library roots.
   
   The top level test library is set with `enablePreview = false` so that
   when compiled they will be able to be used with or without enablePreview.
   
   Individual tests that use preview features and test library files that use
   preview features will need to be compiled based on the settings in each test.
   
   Some tests are modified to remove explicit building or compilation and
   fall back to implicit compiles with the prevaining enablePreview setting.

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1280/files
  - new: https://git.openjdk.org/valhalla/pull/1280/files/c5b384e9..05a0dfda

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1280&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1280&range=00-01

  Stats: 47844 lines in 1517 files changed: 27602 ins; 12490 del; 7752 mod
  Patch: https://git.openjdk.org/valhalla/pull/1280.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1280/head:pull/1280

PR: https://git.openjdk.org/valhalla/pull/1280


More information about the valhalla-dev mailing list