[lworld+fp16] RFR: 8341414: Add support for FP16 conversion routines

Bhavana Kilambi bkilambi at openjdk.org
Mon Oct 28 16:56:06 UTC 2024


On Mon, 28 Oct 2024 12:26:57 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Matcher pattern may also suffice, but the problem will if ConvHF2F has multiple users.
>
> If you check JDK mainline Float16 C2 compiler support PR, John has suggested us to go with pattern matching, I have added more details to that draft PR.

Hi Jatin, thanks for the review comments. I did go through the comments on your draft PR earlier but I wasn't sure if we would be following their comments on the Valhalla branch as yet but I do agree with him about having too many intrinsics being an overkill. I'll remove the `@IntrinsicCandidate` here and add the code to do pattern matching in the mid-end.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1283#discussion_r1819417019


More information about the valhalla-dev mailing list