[lworld] RFR: 8341757: Field layout computation allowing atomic and nullable flattening [v2]

[Frederic Parain]

On Wed, 30 Oct 2024 16:19:41 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix bugs in aarch64 get_default_value_oop() method
>
> src/hotspot/share/gc/shared/barrierSetRuntime.hpp line 41:
> 
>> 39:   // Template interpreter...
>> 40:   static void value_copy(void* src, void* dst, InlineKlass* md);
>> 41:   static void value_copy2(void* src, void* dst, InlineLayoutInfo* layout_info);
> 
> Are there not better names (e.g _ilo) than 2 ? Or is this temp naming ?

This is a temporary naming, once flat arrays have been updated, we can remove the old value_copy() method, and reuse the name for the new method.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1275#discussion_r1823144798