[lworld+fp16] RFR: 8339252: Add method float16Value() to BigInteger and BigDecimal [v3]
Raffaello Giulietti
rgiulietti at openjdk.org
Wed Sep 4 09:34:27 UTC 2024
On Tue, 3 Sep 2024 22:13:19 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More clarification in a comment.
>
> src/java.base/share/classes/java/lang/Float16.java line 286:
>
>> 284: */
>> 285: public static Float16 valueOf(long value) {
>> 286: if (value <= -65_520L) { // -(Float16.MAX_VALUE + Float16.ulp(Float16.MAX_VALUE) / 2)
>
> I assume you'll sync in / merge this change from the branch.
I think this is a remnant due to my previous error to associate the PR to branch `lworld` before moving it to `lworld+fp16`.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1228#discussion_r1743394319
More information about the valhalla-dev
mailing list