[lworld+fp16] RFR: 8339252: Add method float16Value() to BigInteger and BigDecimal [v4]

Joe Darcy darcy at openjdk.org
Wed Sep 4 19:46:33 UTC 2024


On Wed, 4 Sep 2024 19:39:55 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'lworld+fp16' into 8339252
>>  - Clearer code for fullFloat16Value().
>>  - More clarification in a comment.
>>  - 8339252: Add method float16Value() to BigInteger and BigDecimal
>>  - Added valueOf(BigDecimal).
>
> src/java.base/share/classes/java/lang/Float16.java line 437:
> 
>> 435:     }
>> 436: 
>> 437:     //    /**
> 
> Please remove this comment block before pushing.

And the similar comment around line 90.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1228#discussion_r1744328126


More information about the valhalla-dev mailing list