[lworld] RFR: 8331964: [lworld] C2: Support abstract value class fields [v3]

[Christian Hagedorn]

On Wed, 4 Sep 2024 11:25:11 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Addressing remaining review comments
>>  - Fix comment format
>
> src/hotspot/share/compiler/methodLiveness.cpp line 627:
> 
>> 625:           (method->is_object_constructor() &&
>> 626:            ((!holder->is_abstract() && holder->is_inlinetype()) ||
>> 627:             holder->is_abstract()))) {
> 
> Suggestion:
> 
>       if (method->intrinsic_id() == vmIntrinsics::_Object_init ||
>           (method->is_object_constructor() && ((!holder->is_abstract() && holder->is_inlinetype()) || holder->is_abstract()))) {
> 
> 
> It's personal taste but I find this version more readable.

Extracted variables to make this more readable

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1236#discussion_r1744977287