[lworld+fp16] RFR: 8339252: Add method float16Value() to BigInteger and BigDecimal [v6]

[Jatin Bhateja]

On Wed, 4 Sep 2024 21:54:05 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> This patch adds `float16Value()` to `BigInteger` and `BigDecimal`, as well as `Float16.valueOf(BigDecimal)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added @see to valueOf(BigDecimal).

Marked as reviewed by jbhateja (Committer).

src/java.base/share/classes/java/math/BigDecimal.java line 3864:

> 3862:          * Further, as Math.scalb(Float16) does not exists, we fall back to
> 3863:          * Math.scalb(double).
> 3864:          */

FTR @rgiulietti , Thanks for the pointers, comments looks out of context unless read in light of https://github.com/openjdk/valhalla/blob/lworld/src/java.base/share/classes/java/math/BigDecimal.java#L4066

We should add a reference to fullDoubleValue just before your explanation.

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1228#pullrequestreview-2277749861
PR Review Comment: https://git.openjdk.org/valhalla/pull/1228#discussion_r1745325776