[lworld+fp16] RFR: 8339252: Add method float16Value() to BigInteger and BigDecimal [v2]

Jatin Bhateja jbhateja at openjdk.org
Thu Sep 5 12:03:17 UTC 2024


On Tue, 3 Sep 2024 13:03:34 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> test/jdk/java/math/BigInteger/PrimitiveConversionTests.java line 117:
> 
>> 115:         }
>> 116: 
>> 117:         BigInteger large = ONE.shiftLeft(1_000);
> 
> All integers between `-(MAX_VALUE + ULP(MAX_VALUE))` and `(MAX_VALUE + ULP(MAX_VALUE))` are tested in the loop, including `MAX_VALUE + 0.5 * ULP(MAX_VALUE)`.
> 
> But we also need a test for really big integers.

Thanks

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1228#discussion_r1742247288


More information about the valhalla-dev mailing list