[lworld+fp16] RFR: 8339473: Add support for FP16 isFinite, isInfinite and isNaN [v3]

Joe Darcy darcy at openjdk.org
Thu Sep 19 17:21:59 UTC 2024


On Wed, 18 Sep 2024 10:00:36 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> This patch adds intrinsic support for FP16 isNaN, isFinite and isInfinite methods and also adds aarch64 backend for these intrinsics.
>> 
>> Tested all FP16 related tests successfully on aarch64.
>
> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change java side implementation instead of adding intrinsics

src/java.base/share/classes/java/lang/Float16.java line 446:

> 444:      * @see Double#isNaN(double)
> 445:      */
> 446:     public static boolean isNaN(Float16 f16) {

With changing the implementation if isNaN, isFinite, etc. to bit-based, the regression tests should be updated to cover more cases. In particular, different NaN bit patterns should be tested.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1239#discussion_r1767310337


More information about the valhalla-dev mailing list