[lworld+fp16] RFR: 8339473: Add support for FP16 isFinite, isInfinite and isNaN [v3]
Joe Darcy
darcy at openjdk.org
Mon Sep 23 21:33:49 UTC 2024
On Fri, 20 Sep 2024 09:03:05 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/Float16.java line 446:
>>
>>> 444: * @see Double#isNaN(double)
>>> 445: */
>>> 446: public static boolean isNaN(Float16 f16) {
>>
>> With changing the implementation if isNaN, isFinite, etc. to bit-based, the regression tests should be updated to cover more cases. In particular, different NaN bit patterns should be tested.
>
> Hi @jddarcy , thank you for the review. I will add more input patterns to be tested.
Thanks for the update; looks fine.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1239#discussion_r1772141156
More information about the valhalla-dev
mailing list