RFR: 8340125: [lw5] null checks are not being generated for method invocations and array writes

Vicente Romero vromero at openjdk.org
Wed Sep 25 15:12:53 UTC 2024


On Wed, 25 Sep 2024 15:05:40 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> javac is not generating null checks for runtime execution for method invocations and array writes
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java line 1972:
> 
>> 1970:         // outer instance of a super(...) call appears as first parameter).
>> 1971:         MethodSymbol msym = (MethodSymbol)TreeInfo.symbol(tree.meth);
>> 1972:         List<Type> erasedPts = msym.externalType(types).getParameterTypes();
> 
> Should we revert these lines (and others in this class) to whatever is in mainline?

sure will do

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1251#discussion_r1775424953


More information about the valhalla-dev mailing list