[lworld] RFR: 8352647: [lworld] Remove larval InlineTypeNode in Unsafe intrinsics [v2]

[Quan Anh Mai]

On Sun, 30 Mar 2025 13:03:07 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments, set and unset larval bit
>
> src/hotspot/share/opto/library_call.cpp line 2669:
> 
>> 2667:   const Type* type = gvn().type(value);
>> 2668:   if (!type->is_inlinetypeptr()) {
>> 2669:     C->record_method_not_compilable("value passed to Unsafe::makePrivateBuffer is not of a constant value type");
> 
> Suggestion:
> 
>     C->record_method_not_compilable("Argument passed to Unsafe::makePrivateBuffer is not a concrete value type");

I believe we do often not capitalize the first letter passed into `C->record_method_not_compilable`. Additionally, what is passed into `Unsafe::makePrivateBuffer` is a value object, not a concrete value type, and we cannot compile this method because we cannot statically determine the value type this object belongs to, not because the object is not actually a value object. If it is not a value object we will just crash here instead.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1406#discussion_r2023390468