[lworld] RFR: 8352647: [lworld] Remove larval InlineTypeNode in Unsafe intrinsics [v5]

[Quan Anh Mai]

On Fri, 4 Apr 2025 10:28:37 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make it more explicit
>
> Thanks! I'll re-run testing.

@TobiHartmann Thanks a lot for your reviews and testings.

> src/hotspot/share/opto/library_call.cpp line 2669:
> 
>> 2667:   const Type* type = gvn().type(value);
>> 2668:   if (!type->is_inlinetypeptr()) {
>> 2669:     C->record_method_not_compilable("value passed to Unsafe::makePrivateBuffer is not of a constant value type");
> 
> Do we really need to make the method non-compilable?

I think it is better to be conservative, `Unsafe` is a niche and its uses are mostly with a concrete value type so in the rare cases, bailing out would be a safe option. We can definitely relax this restriction afterward if the need arises.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1406#issuecomment-2782199100
PR Review Comment: https://git.openjdk.org/valhalla/pull/1406#discussion_r2030559035