[lworld] RFR: 8355076: [lworld] Incorrect declared_nonstatic_fields computation [v3]

[Quan Anh Mai]

On Tue, 22 Apr 2025 13:02:56 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small adjustments
>
> I could also not reproduce [JDK-8354322](https://bugs.openjdk.org/browse/JDK-8354322) (see details in JBS).

@TobiHartmann 

> Isn't that sufficient?

It can be. I think, however, it is confusing to have `non_static_fields` referring to different things when a type is a concrete class and when it is an abstract class. I also think that `declared_nonstatic_fields` seems not to be something that is only applicable to value classes. As a result, moving it to `ciInstanceKlass` seems to be a logical move.

> I could also not reproduce [JDK-8354322](https://bugs.openjdk.org/browse/JDK-8354322) (see details in JBS).

I believe you need `@Strict @NullRestricted` so that the field is inlined.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1438#issuecomment-2821291408