[lworld] RFR: 8354981: [lworld] Atomic flat stores need preceding CPUMemBar [v2]
Quan Anh Mai
qamai at openjdk.org
Tue Apr 22 17:17:38 UTC 2025
> Hi,
>
> Atomic flat stores cover many memory slices. As a result, it needs a preceding CPUMemBar or else it only takes the slice of the first field as its memory input, which is incorrect.
>
> I don't know how to make a regression test for this. I encounter this crash while working on JDK-8335256. The crash was due to the memory input of the flat store gets split during escape analysis. The compiler then tries looking at the flat stores, which is vastly different from what it expects.
>
> Please take a look and leave your reviews, thanks a lot.
Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- Merge branch 'lworld' into fixatomicstore
- Atomic flat store needs a preceding barrier
-------------
Changes: https://git.openjdk.org/valhalla/pull/1437/files
Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=1437&range=01
Stats: 28 lines in 1 file changed: 12 ins; 10 del; 6 mod
Patch: https://git.openjdk.org/valhalla/pull/1437.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1437/head:pull/1437
PR: https://git.openjdk.org/valhalla/pull/1437
More information about the valhalla-dev
mailing list