[lworld] Integrated: 8354981: [lworld] Atomic flat stores need preceding CPUMemBar
Quan Anh Mai
qamai at openjdk.org
Wed Apr 23 13:31:52 UTC 2025
On Thu, 17 Apr 2025 16:58:19 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
> Hi,
>
> Atomic flat stores cover many memory slices. As a result, it needs a preceding CPUMemBar or else it only takes the slice of the first field as its memory input, which is incorrect.
>
> I don't know how to make a regression test for this. I encounter this crash while working on JDK-8335256. The crash was due to the memory input of the flat store gets split during escape analysis. The compiler then tries looking at the flat stores, which is vastly different from what it expects.
>
> Please take a look and leave your reviews, thanks a lot.
This pull request has now been integrated.
Changeset: 4bd22a85
Author: Quan Anh Mai <qamai at openjdk.org>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL: https://git.openjdk.org/valhalla/commit/4bd22a85b1936aaa89a578f5827510ab062eb169
Stats: 28 lines in 1 file changed: 12 ins; 10 del; 6 mod
8354981: [lworld] Atomic flat stores need preceding CPUMemBar
Reviewed-by: thartmann
-------------
PR: https://git.openjdk.org/valhalla/pull/1437
More information about the valhalla-dev
mailing list