[lworld] RFR: 8354068: [lworld] Fold strict final fields more aggressively [v2]
Quan Anh Mai
qamai at openjdk.org
Thu Apr 24 14:28:52 UTC 2025
On Thu, 24 Apr 2025 13:37:05 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> That's right, I have added a case when valhalla is not enabled to catch `is_ptr_to_boxed_value` then.
>
> But what I mean is that before your changes, we also executed this code if `t_oop->is_ptr_to_boxed_value()` was true but now we bail out. And if EnableValhalla is false, and primitive boxes are not value classes, we would therefore not optimize loads from those boxes anymore, right?
In my latest commit, I mark `is_strict_final_load` as `true` if `t_oop->is_ptr_to_boxed_value()` is `true` when `EnableValhalla` is `false`. Is it what you want, or I am missing something here?
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1424#discussion_r2058580109
More information about the valhalla-dev
mailing list