[lworld] RFR: 8355397: [lworld] Parse::array_load fails with "array can't be flat" assert [v2]

duke duke at openjdk.org
Tue Apr 29 20:07:21 UTC 2025


On Mon, 28 Apr 2025 14:46:42 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> The issue here is that `InstanceKlass::flat_array` is too strict and it rejects any class that is atomic and has more than 1 field. I remove the unnecessary restrictions and rename the method to `maybe_flat_in_array` to illustrate the functionality in a clearer manner.
>> 
>> Please kindly review, thanks a lot.
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'lworld' into flatinarray
>  - add tests
>  - fix InstanceKlass::flat_array

@merykitty 
Your change (at version 926298dd7fd7eabebfdfd5070a32724d66dc7e1c) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1446#issuecomment-2840108165


More information about the valhalla-dev mailing list