[lworld] RFR: 8364191: [lworld] Accesses to atomic flat fields prevent scalar replacement [v3]
Quan Anh Mai
qamai at openjdk.org
Thu Aug 7 13:34:54 UTC 2025
> Hi,
>
> Flat accesses prevent scalar replacement because they are mismatched accesses. It is also generally not possible to look through them, because the payload may contain an oop in the form of raw bits. As a result, this PR adds `LoadFlatNode` and `StoreFlatNode`, which act as high-level abstractions for atomic accesses on flat fields. When it is determined that there is no racing access on the flat field (e.g. because the holder object does not escape), these flat access nodes can be expanded into multiple accesses to each flattened fields, otherwise, they will be expanded into a sequence of inferring a payload and accessing memory with that payload.
>
> I also fix an issue with deoptimization reallocation where we miss assigning the null marker of elements in a nullable flat array.
>
> Please take a look and leave your reviews, thanks a lot.
Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
fix release build
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1518/files
- new: https://git.openjdk.org/valhalla/pull/1518/files/428b656c..eb23f4e5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1518&range=02
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1518&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/valhalla/pull/1518.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1518/head:pull/1518
PR: https://git.openjdk.org/valhalla/pull/1518
More information about the valhalla-dev
mailing list