[lworld] RFR: 8360851: [lworld] missing # {method} comment in assembly dumping [v3]

[duke]

On Mon, 25 Aug 2025 07:26:54 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> `CodeOffsets::Verified_Inline_Entry` and `CodeOffsets::Verified_Inline_Entry` are special among entry point code offsets because they can be disabled with a value of `-1`. The code installation for hotspot deals with this by just setting both to the same value as `CodeOffsets::Verified_Entry` if they are disabled. JVMCI code installation on the other hand, leaves the offsets at `-1`. When printing the assembly of a JVMCI compiled method where both offsets are disabled, the method name is not printed together with the entry point labels. This is due to the disabled entry points having the lowest address due to their negative offset and those disabled entry points thus pointing to an address before the block that is being printed:
>> 
>> https://github.com/openjdk/valhalla/blob/af03598eb81aee17c0657347fd6439475ca8f7ee/src/hotspot/share/code/nmethod.cpp#L3788-L3796
>> 
>> This PR fixes this issue by checking if the entry points that can be disabled point into the code block that is being printed. The regression test is botched together from two existing tests, due to my inexperience with JVMCI (but it works). Suggestions for a better test are welcome.
>> 
>> Testing:
>>  - [x] tier1,tier2,tier3,valhalla-comp-stress
>
> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address Tobias' comments

@mhaessig 
Your change (at version 61143ad3839e906729e55d14c6d3cfdef0ae379e) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1529#issuecomment-3219202585