[lworld] RFR: 8361352: [lworld] Weird interaction between OSR and value class instances [v2]

[Tobias Hartmann]

On Mon, 25 Aug 2025 09:04:32 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> src/hotspot/share/ci/ciType.cpp line 151:
>> 
>>> 149:   assert(type->is_inlinetype()
>>> 150:              // An abstract value type is an instance_klass
>>> 151:              || (type->is_instance_klass() && type->as_instance_klass()->flags().is_abstract() && !type->as_instance_klass()->flags().is_identity())
>> 
>> Just wondering, is the `type->as_instance_klass()->flags().is_abstract()` condition even needed? Same in `ciTypeFlow::get_start_state()`.
>
> Probably not. An instance class without identity must be an abstract value class. At least, I don't see another way... But just to be sure, I'm running some tests.

Right, I think so too. Thanks for checking!

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1531#discussion_r2297588486