[lworld] RFR: 8366200: Modify existing use of jimage fields to make space for preview mode flags [v2]

David Beaumont duke at openjdk.org
Thu Aug 28 14:32:55 UTC 2025


On Wed, 27 Aug 2025 16:39:36 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> David Beaumont has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - 8366200: Modify existing use of jimage fields to make space for preview mode flags
>>  - remove dead code
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java line 161:
> 
>> 159:         }
>> 160: 
>> 161:         Stream<PackageReference> sortedRefs() {
> 
> Method name: "Refs" is pretty generic, in a class named ResourceTree.
> How about sortedPackageRefs().

I mean it's in a class called `PackageNode` really (and isn't public), but I take your point.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1534#discussion_r2307595731


More information about the valhalla-dev mailing list