[lworld] RFR: 8359370: [lworld] allow instance fields of identity classes to be readable in the prologue phase [v13]

Vicente Romero vromero at openjdk.org
Thu Aug 28 20:23:02 UTC 2025


On Thu, 28 Aug 2025 16:43:43 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor diff
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1363:
> 
>> 1361:                 try {
>> 1362:                     analyzingSelect = true;
>> 1363:                     super.visitSelect(tree);
> 
> Can't we cut recursion here (instead of using `analyzingSelect` ? That's also what the new `TreeInfo.symbolsFor` does. In general it seems like these two visitors are trying to do similar things but are not 100% aligned?

if one has a complex select like for example: `new SuperInitFails(){}.x` it is still necessary to look inside and see if there are some forbidden accesses

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1523#discussion_r2308451043


More information about the valhalla-dev mailing list