[lworld] RFR: 8357373: [lworld] jdk/valhalla/valuetypes/ObjectMethods.java fails with -XX:+UseAtomicValueFlattening [v2]

Volkan Yazici vyazici at openjdk.org
Fri Dec 5 14:34:03 UTC 2025


On Fri, 5 Dec 2025 14:28:44 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> test/jdk/valhalla/valuetypes/ValueObjectMethodsTest.java line 280:
>> 
>>> 278:     @MethodSource("hashcodeTests")
>>> 279:     public void testHashCode(List<Object> objects) {
>>> 280:         assertTrue(objects.size() > 1, "More than one object is required: " + objects);
>> 
>> _Nit:_ I doubt if displaying `[]` will contribute much to the diagnostics context.
>> 
>> Suggestion:
>> 
>>         assertFalse(objects.isEmpty(), "More than one object is required");
>
> Every little bit helps.  
> (`isEmpty` is not equivalent to `>1`)

You're right, nevermind.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1771#discussion_r2592896967


More information about the valhalla-dev mailing list