[lworld] RFR: 8373567: [lworld] Move array copy exception throwing out of GC barriers [v2]

[Dan Heidinga]

On Fri, 12 Dec 2025 10:07:21 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The lworld branch has support for null-restricted arrays, and to support this code has been adjacent to the code that perform array copy check casts. The code that performs the check casts used to be located inside the GC access barriers, but the code that finally threw exceptions were located in the runtime code. In the lworld branch the code that throws the check cast exception and the new null pointer exception has been moved into the GC access barriers.
>> 
>> I propose that we revert back to the old style where the exception throwing was somewhat decoupled from the GC access barriers.
>
> Stefan Karlsson has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Mark oop_arraycopy as nodiscard
>  - Terminate OopCopyResult in oop_arraycopy_raw

src/hotspot/share/oops/access.hpp line 335:

> 333:   }
> 334: 
> 335:   [[nodiscard]]

Is it worth leaving a comment on why the `[[nodiscard]]` annotation was used here?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1792#discussion_r2619949491