[lworld] RFR: 8372113: [lworld] Fix various issues with TypeAryPtr and TypeAryKlassPtr [v9]

[Tobias Hartmann]

On Mon, 15 Dec 2025 11:39:16 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This PR fixes various issues with `TypeAryPtr` and `TypeAryKlassPtr`. It starts with me trying to tighten the properties (`flat`, `null_free`, etc) of these classes, then fixing all the revealed issues until there are no crashes or wrong results left.
>> 
>> Please take a look and leave your reviews, thanks a lot.
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge branch 'lworld' into AryKlassPtrfactory
>  - reviews
>  - reviews
>  - Should not clone MergeMem
>  - fix NarrowMemProj
>  - Merge branch 'lworld' into AryKlassPtrfactory
>  - Fix Parse::array_store and PhaseMacroNode::value_from_mem
>  - whitespace
>  - fix more issues
>  - Merge branch 'lworld' into AryKlassPtrfactory
>  - ... and 2 more: https://git.openjdk.org/valhalla/compare/2f2fd63d...84605fc1

Sure! It looks good but there is one failure left:


compiler/valhalla/inlinetypes/TestArrayNullMarkers.java
-Xcomp -XX:-TieredCompilation -DIgnoreCompilerControls=true
OR
-XX:+UnlockExperimentalVMOptions -XX:PerMethodSpecTrapLimit=0 -XX:PerMethodTrapLimit=0

# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/workspace/open/src/hotspot/share/opto/escape.cpp:4276), pid=2237007, tid=2237024
#  assert(idx == alias_idx) failed: Following Phi nodes should be on the same memory slice
#
# JRE version: Java(TM) SE Runtime Environment (26.0) (fastdebug build 26-jep401ea2-2025-12-15-1150217.tobias.hartmann.valhallatesting)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (fastdebug 26-jep401ea2-2025-12-15-1150217.tobias.hartmann.valhallatesting, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xe2e206]  ConnectionGraph::move_inst_mem(Node*, GrowableArray<PhiNode*>&)+0x6c6
#

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1755#issuecomment-3659173863