[lworld] RFR: 8373575: [lworld] Fix and problem list failing JDK, langtools and HotSpot tier 1 tests under --enable-preview [v5]

Paul Hübner phubner at openjdk.org
Tue Dec 16 09:19:42 UTC 2025


On Mon, 15 Dec 2025 21:11:34 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> test/langtools/tools/javap/T4975569.java line 30:
>> 
>>> 28:  * @modules jdk.jdeps/com.sun.tools.javap
>>> 29:  * @modules java.base/jdk.internal.misc
>>> 30:  * @requires !java.enablePreview
>> 
>> Why is  `@requires !java.enablePreview` needed here? The test's `id` value is `NoPreview` so that might
>> indicate that the test doesn't support `--enable-preview` bits, but I had to expand the review's context
>> to see that `id` value.
>
> Another thought occurred to me. Perhaps add a comment line above the `@requires`:
> 
> @comment Test does not like Valhalla value classes.
> 
> or something like that. I think it would be good if we added a comment
> when we use `@requires !java.enablePreview` to indicate which preview
> feature is problematic.

Added a comment.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1793#discussion_r2622449562


More information about the valhalla-dev mailing list