[lworld] RFR: 8373779: [lworld] Type confusion with InlineKlassFixedBlock fields
Stefan Karlsson
stefank at openjdk.org
Tue Dec 16 14:34:26 UTC 2025
On Tue, 16 Dec 2025 13:47:57 GMT, Frederic Parain <fparain at openjdk.org> wrote:
> The name InlineKlassFixedBlock has no particular meaning. It was just the name given to the struct when we stopped adding/removing individual inline klass fields to the variable section, and put all of them in a single block easier to manage. It could be renamed to something more meaningful like InlineKlassExtraFields. Which name would you prefer?
Thanks. Then I might get around to figuring out another name for it.
> Thank you for this nice cleanup. The InlineKlassFixedBlock should be declared in inlineKlass.hpp, but for some reasons I forgot, it was not possible when initially added, this is why it ended in instanceKlass.hpp unfortunately. Fixing this oddity in a different CR is fine.
The main reason I could find is that the size calculation in instanceKlass.cpp uses `sizeof(InlineKlassFixedBlock)`. That can be fixed by making a slight alteration to the allocation code + adding `size()` overload in `InlineKlass`.
I'll create a PR for that and then people can see if they like it or not.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1803#issuecomment-3660842597
PR Comment: https://git.openjdk.org/valhalla/pull/1803#issuecomment-3660852280
More information about the valhalla-dev
mailing list