[lworld] RFR: 8373787: [lworld] InstanceKlass::size mixes bytes and words

[Paul Hübner]

On Tue, 16 Dec 2025 14:26:59 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/oops/instanceKlass.hpp line 1050:
>> 
>>> 1048:            nonstatic_oop_map_size +
>>> 1049:            (is_interface ? (int)sizeof(Klass*) / wordSize : 0) +
>>> 1050:            (is_inline_type ? (int)sizeof(InlineKlassFixedBlock) / wordSize : 0));
>> 
>> Do we have an `x / wordSize` helper function anywhere? Too much inline arithmetic makes it hard to maintain, imo.
>
> I couldn't find. And there's a very large number of these in the code base. I think this would be a cleanup that one would do outside of the Valhalla project.

Agree, doesn't make sense to do it for this change let alone Valhalla.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1804#discussion_r2623582535