[lworld] RFR: 8372515: [lworld] Plumb in javac flags for compiling with preview mode [v5]

[duke]

On Tue, 16 Dec 2025 14:22:48 GMT, David Beaumont <duke at openjdk.org> wrote:

>> Plumbing for javac flags, mostly inspired by/copied from test commits made by @lahodaj .
>> 
>> There are several things here, mostly entangled, so it's a bit tricky to try splitting this out, but it would be possible if people wanted.
>> 
>> The biggest "refactoing" part of this PR is "src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java" which now has a properly controlled lifecycle and disposed its resources correctly. Prior to this, the class used a non-closeable JRT file-system reference, which leads to "persistent open file" issues such as JDK-8357249.
>> 
>> This *does* mean that if compilation and the runtime have the same preview mode, then a 2nd JRT file system to the same jimage file is "opened", *but* the file system itself is lightweight, non-caching and both of them will use the underlying SharedImageReader (which is where nodes are cached etc.) so it really shouldn't be an issue (I will make sure javac benchmarks are checked however).
>> 
>> The benefit of this is that now, the shared index (which does do some caching) is correctly tracked across all users, and will be closed when the last user closes the lightweight wrapper instance.
>> 
>> A lot of the smaller "spot fix" changes in this PR were just copied by me, or at least inspired directly by Jan's work, so I may have missed some semantic subtlety in the code I'm not familiar with. Please evaluate that carefully.
>
> David Beaumont has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Merge branch 'lworld' into plumbing
>  - correct assertion
>  - review feedback
>  - remove automatic formatting
>  - comments
>  - Remove note about StableValue (not possible)
>  - Use byte array not stream for simplicity
>  - properties fix
>  - Arguments fix, tweak close method
>  - with extra patches
>  - ... and 1 more: https://git.openjdk.org/valhalla/compare/4e04540c...5dba9c85

@david-beaumont 
Your change (at version 5dba9c8595d2644ed070b6a0b6d85753204265ca) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1761#issuecomment-3660995773