[lworld] RFR: 8371357: [lworld] Remove EnableValhalla [v6]
Paul Hübner
phubner at openjdk.org
Wed Dec 17 10:52:57 UTC 2025
On Tue, 16 Dec 2025 16:23:12 GMT, Paul Hübner <phubner at openjdk.org> wrote:
>> Hi all,
>>
>> This removes the `EnableValhalla` in favour of the `--enable-preview` flag. Concretely:
>> * I've replaced most of the `EnableValhalla` checks with `Arguments::is_valhalla_enabled()`.
>> * Some checks were redundant and could be removed entirely.
>> * I've made the `EnableValhalla` flag obsolete.
>> * Some tests had to be updated.
>>
>> This greatly changes the semantics of tests. I've refined some test groups to make it easier.
>>
>> Testing: tiers 1-4.
>
> Paul Hübner has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits:
>
> - Merge branch 'lworld' into JDK-8371357
> - Merge branch 'lworld' into JDK-8371357
> - Reviewer comments.
> - Use the new function for the Parallel changes.
> - Merge branch 'lworld' into JDK-8371357
> - Remove wrong comment.
> - Fix imports.
> - Reviewer comments.
> - Copyright.
> - Revert "Don't synchronize on Double."
>
> This reverts commit cbf849c2ce6059af2b43b3dd8cb42445eab4df2b.
> - ... and 16 more: https://git.openjdk.org/valhalla/compare/ef301b76...6eae2446
Thanks all for the diligent feedback and reviews.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1759#issuecomment-3664779812
More information about the valhalla-dev
mailing list