[lworld] RFR: 8373826: [lworld] Test PreviewAutoSuppress fails since jimage change
Roger Riggs
rriggs at openjdk.org
Wed Dec 17 14:39:07 UTC 2025
On Wed, 17 Dec 2025 13:33:25 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> Fixing `test/langtools/tools/javac/diags/CheckExamples.java` (`test/langtools/tools/javac/diags/examples/PrimitivePatternMatching.java`) and `test/langtools/tools/javac/preview/PreviewAutoSuppress.java` tests.
>
> Unfortunately, it is quite hard to make the tests work both with and without `-DDISABLE_PREVIEW_PATCHING=true` (could be done for `PreviewAutoSuppress.java`, but it is very hard to do sensible for `CheckExamples.java`), so given the future is `-DDISABLE_PREVIEW_PATCHING=true`, this change forces this option. (The practical impact of testing only this variant for these two tests is basically zero, I think. We have a different test that verifies all the combinations.)
looks good.
Please undo the problem listing in [ttps://git.openjdk.org/valhalla/pull/1815](https://git.openjdk.org/valhalla/pull/1815)
fyi, we've switched the default to use JImage full time. The conditional will become dead code and be removed.
fyi, I see a Problem listing of both tests has been done in [ttps://git.openjdk.org/valhalla/pull/1815](https://git.openjdk.org/valhalla/pull/1815).
Please merge and remove the problem listing.
-------------
Marked as reviewed by rriggs (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1813#pullrequestreview-3588049506
Changes requested by rriggs (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1813#pullrequestreview-3588056253
PR Comment: https://git.openjdk.org/valhalla/pull/1813#issuecomment-3665637956
PR Comment: https://git.openjdk.org/valhalla/pull/1813#issuecomment-3665645745
More information about the valhalla-dev
mailing list