[lworld] RFR: 8372113: [lworld] Fix various issues with TypeAryPtr and TypeAryKlassPtr [v10]
Quan Anh Mai
qamai at openjdk.org
Wed Dec 17 17:39:39 UTC 2025
On Wed, 17 Dec 2025 15:18:04 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hi,
>>
>> This PR fixes various issues with `TypeAryPtr` and `TypeAryKlassPtr`. It starts with me trying to tighten the properties (`flat`, `null_free`, etc) of these classes, then fixing all the revealed issues until there are no crashes or wrong results left.
>>
>> Please take a look and leave your reviews, thanks a lot.
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>
> - ArrayProperties needs to agree with LayoutKind
> - Merge branch 'lworld' into AryKlassPtrfactory
> - Merge branch 'lworld' into AryKlassPtrfactory
> - reviews
> - reviews
> - Should not clone MergeMem
> - fix NarrowMemProj
> - Merge branch 'lworld' into AryKlassPtrfactory
> - Fix Parse::array_store and PhaseMacroNode::value_from_mem
> - whitespace
> - ... and 4 more: https://git.openjdk.org/valhalla/compare/1077e4f9...bdd91920
I have resolved the merge conflict and the failure. The issue was that the properties of an `ArrayKlass` do not agree with its layout kind. What I did was to normalize the properties after layout selection.
@fparain What do you think? Thanks a lot.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1755#issuecomment-3666442763
More information about the valhalla-dev
mailing list